Fix IndexOutOfBoundsException when running include/exclude with non-existent prefix term #19637
+156
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavamsi
requested review from
a team,
Bukhtawar,
CEHENKLE,
Rishikesh1159,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
Contributor
Author
|
@msfroh could you take a look since you added this optimization |
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
harshavamsi
force-pushed
the
fix-prefix-ordinals-index-out-of-bounds
branch
from
e90ffb1 to
7f1e867
Compare
Contributor
|
❌ Gradle check result for 7f1e867: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Contributor
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
github-project-automation
bot
moved this from In-Review
to In Progress
in Performance Roadmap
Contributor
Signed-off-by: Ankit Jain <[email protected]>
Contributor
|
❌ Gradle check result for d6eb8db: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
Another flaky test: cc: @kaushalmahi12 / @ruai0511 |
Contributor
github-project-automation
bot
moved this from In Progress
to Done
in Performance Roadmap
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-19637-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 09b3b962cdbb703591fe7422f6eecad541f89c45
# Push it to GitHub
git push --set-upstream origin backport/backport-19637-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.xThen, create a pull request where the |
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.19 2.19
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.19
# Create a new branch
git switch --create backport/backport-19637-to-2.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 09b3b962cdbb703591fe7422f6eecad541f89c45
# Push it to GitHub
git push --set-upstream origin backport/backport-19637-to-2.19
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.19Then, create a pull request where the |
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-3.3 3.3
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-3.3
# Create a new branch
git switch --create backport/backport-19637-to-3.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 09b3b962cdbb703591fe7422f6eecad541f89c45
# Push it to GitHub
git push --set-upstream origin backport/backport-19637-to-3.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-3.3Then, create a pull request where the |
jainankitk
added a commit
that referenced
this pull request
Oct 28, 2025
…xistent prefix term (#19637) Signed-off-by: Harsha Vamsi Kalluri <[email protected]> Signed-off-by: Ankit Jain <[email protected]> Co-authored-by: Ankit Jain <[email protected]> (cherry picked from commit 09b3b96)
3 tasks
jainankitk
added a commit
that referenced
this pull request
Oct 28, 2025
…xistent prefix term (#19637) Signed-off-by: Harsha Vamsi Kalluri <[email protected]> Signed-off-by: Ankit Jain <[email protected]> Co-authored-by: Ankit Jain <[email protected]> (cherry picked from commit 09b3b96)
3 tasks
Contributor
|
Created the backport PRs for 2.19 and 3.3. Don't need to backport for |
jainankitk
added a commit
that referenced
this pull request
Oct 28, 2025
…xistent prefix term (#19637) (#19792) (cherry picked from commit 09b3b96) Signed-off-by: Harsha Vamsi Kalluri <[email protected]> Signed-off-by: Ankit Jain <[email protected]> Co-authored-by: Harsha Vamsi Kalluri <[email protected]>
anandpatel9998
pushed a commit
to anandpatel9998/OpenSearch
that referenced
this pull request
Nov 3, 2025
…xistent prefix term (opensearch-project#19637) Signed-off-by: Harsha Vamsi Kalluri <[email protected]> Signed-off-by: Ankit Jain <[email protected]> Co-authored-by: Ankit Jain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in #19636, we check the bounds of the ordinal before we seek
Related Issues
Resolves #19636
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.